-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Link to the quota project docs in the quota management section #12860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
||
Service account credentials are associated with the project the service account | ||
was created in. Credentials that come from the gcloud tool are associated with a | ||
project owned by Google. In order to properly use credentials that come from | ||
gcloud with Terraform, it is recommended to set this property to true. | ||
gcloud with Terraform, it is recommended to set this property to `true`. | ||
|
||
`user_project_override` uses the `X-Goog-User-Project` | ||
[system parameter](https://cloud.google.com/apis/docs/system-parameters). When |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally unrelated to our documentation and probably just my own unfamiliarity with API documentation, but I am not a fan of "system parameter" being the official terminology as the usage of "system" feels like it should be describing local or upstream based variables as opposed to request ones (hence my confusion in the chat discussion).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I am not a big fan of the naming :(
This page has existed for ~ a year I think, so we're a bit behind on referencing it. Finally a clear and explicit page on c.g.c for this stuff!
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.