Skip to content

Update resource SCC Mute Config with expiry time field #12979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vijaykanthm
Copy link
Contributor

@vijaykanthm vijaykanthm commented Feb 6, 2025

Related to http://b/377317615.

Issue Description: hashicorp/terraform-provider-google#20137

This PR updates the mute config with expiry time field to support dynamic mute rule configuration.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

securitycenter: added `type`, `expiry_time` field to `google_scc_mute_config` resource

Copy link

github-actions bot commented Feb 6, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 171 insertions(+))
google-beta provider: Diff ( 5 files changed, 171 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securitycenter

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterMuteConfig
  • TestAccSecurityCenterMuteConfig_sccMuteConfigExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecurityCenterMuteConfig [Error message] [Debug log]
TestAccSecurityCenterMuteConfig_sccMuteConfigExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…hub.com:vijaykanthm/magic-modules into add-expiry-time-field-to-google-scc-mute-config

Merge remote to local.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 171 insertions(+))
google-beta provider: Diff ( 5 files changed, 171 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securitycenter

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterMuteConfig
  • TestAccSecurityCenterMuteConfig_sccMuteConfigExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSecurityCenterMuteConfig [Debug log]
TestAccSecurityCenterMuteConfig_sccMuteConfigExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants