Skip to content

Set PageSize to 1000 when fetch images from GAR #12993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

shohei-ihaya
Copy link
Contributor

@shohei-ihaya shohei-ihaya commented Feb 7, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

artifactregistry: set pageSize to 1000 to speedup data.google_artifact_registry_docker_image queries

fix: hashicorp/terraform-provider-google#21291

Copy link

google-cla bot commented Feb 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

github-actions bot commented Feb 7, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from c2thorn February 7, 2025 07:13
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/artifactregistry and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 7, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • artifactregistry

🟢 All tests passed!

View the build log

Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@c2thorn c2thorn added this pull request to the merge queue Feb 11, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 00d63e4 Feb 11, 2025
19 of 23 checks passed
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data.google_artifact_registry_docker_image is very slow when repository has many images
4 participants