Skip to content

Add policyMode field #13013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JaylonmcShan03
Copy link
Contributor

@JaylonmcShan03 JaylonmcShan03 commented Feb 10, 2025

Addresses hashicorp/terraform-provider-google#18837

This pr adds the policyMode field to the google_network_connectivity_hub resource.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networkconnectivity: added `policy_mode` field to `google_network_connectivity_hub` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from shuyama1 February 10, 2025 01:10
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/network-connectivity-center and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 10, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 31 insertions(+))
google-beta provider: Diff ( 3 files changed, 31 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_hub (35 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_hub" "primary" {
  policy_mode = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 34
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkconnectivity

🟢 All tests passed!

View the build log

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 31 insertions(+))
google-beta provider: Diff ( 3 files changed, 31 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_hub (35 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_hub" "primary" {
  policy_mode = # value needed
}

@github-actions github-actions bot requested a review from shuyama1 February 18, 2025 00:44
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 18, 2025
Copy link

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 20, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 31 insertions(+))
google-beta provider: Diff ( 3 files changed, 31 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_hub (35 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_hub" "primary" {
  policy_mode = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 34
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkconnectivity

🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from shuyama1 February 24, 2025 13:38
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 24, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 91 insertions(+))
google-beta provider: Diff ( 4 files changed, 91 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 111 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 36
Passed tests: 34
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivityHub_networkConnectivityHubPolicyModeExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivityHub_networkConnectivityHubPolicyModeExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@shuyama1 shuyama1 added this pull request to the merge queue Feb 25, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 0d083f8 Feb 25, 2025
22 checks passed
maxi-cit pushed a commit to maxi-cit/magic-modules that referenced this pull request Feb 27, 2025
NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Mar 13, 2025
JaylonmcShan03 added a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 added a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants