Skip to content

Adds google_storage_anywhere_cache resource #13023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

googlyrahman
Copy link
Member

`google_storage_anywhere_cache`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from melinath February 10, 2025 16:35
@googlyrahman googlyrahman force-pushed the cache branch 2 times, most recently from e186613 to eac8289 Compare February 10, 2025 16:37
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

1 similar comment
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the tests are missing the time provider.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 883 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 7 files changed, 883 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 119
Passed tests: 108
Skipped tests: 9
Affected tests: 2

Click here to see the affected service packages
  • storage

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageAnywhereCache_basic
  • TestAccStorageAnywhereCache_storageAnywhereCacheBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccStorageAnywhereCache_basic [Error message] [Debug log]
TestAccStorageAnywhereCache_storageAnywhereCacheBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from melinath February 19, 2025 19:36
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 887 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 7 files changed, 887 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 91 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 119
Passed tests: 108
Skipped tests: 9
Affected tests: 2

Click here to see the affected service packages
  • storage

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageAnywhereCache_basic
  • TestAccStorageAnywhereCache_storageAnywhereCacheBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageAnywhereCache_storageAnywhereCacheBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccStorageAnywhereCache_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

"testing"
)

func TestAccStorageAnywhereCache_basic(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: _update to indicate this is an update test.

Suggested change
func TestAccStorageAnywhereCache_basic(t *testing.T) {
func TestAccStorageAnywhereCache_update(t *testing.T) {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@github-actions github-actions bot requested a review from melinath February 20, 2025 21:51
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 895 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 7 files changed, 895 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 91 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 119
Passed tests: 109
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • storage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageAnywhereCache_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageAnywhereCache_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants