Update create_url updateMask for google_chronicle_rule_deployment res…

[ankitgoyal0301]

…ource

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

chronicle: fixed creation issues when optional fields were missing for `google_chronicle_rule_deployment` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 18 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 17
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• chronicle

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample
• TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample [Debug log]
TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[ScottSuarez]

Is there more context on this change? What issue might it be fixing and would that be testable?

It's possible this is just a difference of implementation?

[ankitgoyal0301]

Is there more context on this change? What issue might it be fixing and would that be testable?

It's possible this is just a difference of implementation?

@ScottSuarez So, run_frequency is an optional field for us. Now, during the create call, just assume a case that you don't specify it in your terraform code. Now the updateMask in create_url has run_frequency param (and infact all 4 params, which is the case before this PR because create_url updateMask is hardcoded), the API complains, because it expects a value of the params if they are in updateMask.

This PR is to fix the issue that if you don't pass "run_frequency" during your terraform create call for a rule_deployment resource, it won't complain and work as expected.