Adding Apigee Dns Zone resource support

[sauragrawal]

Adding support for google_apigee_dns_zone resource

Fixes: hashicorp/terraform-provider-google#21391

Release Note Template for Downstream PRs (will be copied)

`google_apigee_dns_zone`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 640 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 780 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 17
Skipped tests: 37
Affected tests: 1

Click here to see the affected service packages

• apigee

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeDnsZone_apigeeDnsZoneBasicTestExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@sauragrawal, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 644 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 784 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 18
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeDnsZone_apigeeDnsZoneBasicTestExample
  🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 627 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 767 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 18
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeDnsZone_apigeeDnsZoneBasicTestExample
  🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 627 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 767 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 18
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeDnsZone_apigeeDnsZoneBasicTestExample
  🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 627 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 767 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 18
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeDnsZone_apigeeDnsZoneBasicTestExample
  🟢 All tests passed!

View the build log

[melinath]

manual test run: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_APIGEE/332876

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 627 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 767 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 18
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeDnsZone_apigeeDnsZoneBasicTestExample
  🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 627 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 775 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 18
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeDnsZone_apigeeDnsZoneBasicTestExample
  🟢 All tests passed!

View the build log

[melinath]

manual test run: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_APIGEE/342006

[melinath]

Sorry for the rework, but it looks like I was wrong (misinterpreted the test failure last time around) and the custom_import is necessary. Specifically, the problem is that orgId contains the organizations/ part as well. It could be possible to make this behave in a more normal way but then it would potentially diverge from other apigee resources.

The test failure is now:

        Error: Import id "organizations/tf-testqi46wps6k0/dnsZones/tf-testqi46wps6k0" doesn't match any of the accepted formats: [^(?P<org_id>[^/]+)/dnsZones/(?P<dns_zone_id>[^/]+)$ ^(?P<org_id>[^/]+)/(?P<dns_zone_id>[^/]+)$]

[melinath]

Adding % here would let org_id contain /, and would probably work. But you wouldn't get the same level of information in error messages if users specify it wrong.

Suggested change

	- '{{org_id}}/dnsZones/{{dns_zone_id}}'
	- '{{org_id}}/{{dns_zone_id}}'
	- '{{%org_id}}/dnsZones/{{dns_zone_id}}'
	- '{{%org_id}}/{{dns_zone_id}}'

[sauragrawal]

Added the custom import code

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 644 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 792 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 121 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 18
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeDnsZone_apigeeDnsZoneBasicTestExample
  🟢 All tests passed!

View the build log

[melinath]

manual test run: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_APIGEE/342019