fix: (storagetransfer) added logging_config for storage transfer job

[gurusai-voleti]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storagetransfer: added `logging_config` field to `google_storage_transfer_job` resource

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 104 insertions(+))
google-beta provider: Diff ( 2 files changed, 104 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 6
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages

• storagetransfer

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageTransferJob_basic
• TestAccStorageTransferJob_eventStream
• TestAccStorageTransferJob_notificationConfig
• TestAccStorageTransferJob_objectConditions
• TestAccStorageTransferJob_posixSink
• TestAccStorageTransferJob_posixSource
• TestAccStorageTransferJob_transferOptions

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccStorageTransferJob_basic [Debug log]
TestAccStorageTransferJob_notificationConfig [Debug log]
TestAccStorageTransferJob_objectConditions [Debug log]
TestAccStorageTransferJob_posixSink [Debug log]
TestAccStorageTransferJob_posixSource [Debug log]
TestAccStorageTransferJob_transferOptions [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccStorageTransferJob_eventStream [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 128 insertions(+))
google-beta provider: Diff ( 3 files changed, 128 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• storagetransfer

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageTransferJob_eventStream

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccStorageTransferJob_eventStream [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 128 insertions(+))
google-beta provider: Diff ( 3 files changed, 128 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• storagetransfer

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 125 insertions(+))
google-beta provider: Diff ( 3 files changed, 125 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• storagetransfer

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 126 insertions(+))
google-beta provider: Diff ( 3 files changed, 126 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• storagetransfer

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 125 insertions(+))
google-beta provider: Diff ( 3 files changed, 125 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• storagetransfer

🟢 All tests passed!

View the build log

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[kautikdk]

As LoggingConfig is a top level field for the Transfer Job, I would suggest adding separate test with update steps rather than adding logging_config in unrelated tests.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 125 insertions(+))
google-beta provider: Diff ( 3 files changed, 125 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• storagetransfer

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 399 insertions(+))
google-beta provider: Diff ( 3 files changed, 399 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• storagetransfer

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageTransferJob_posixSource
• TestAccStorageTransferJob_updateLoggingConfig

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccStorageTransferJob_posixSource [Debug log]
TestAccStorageTransferJob_updateLoggingConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[gurusai-voleti]

As LoggingConfig is a top level field for the Transfer Job, I would suggest adding separate test with update steps rather than adding logging_config in unrelated tests.

updated testcase with logging config

[JordanLoehr]

Just FYI this dupes this PR #12980 for the associated issue hashicorp/terraform-provider-google#21254

[c2thorn]

LGTM - thanks for adding the update test.

[c2thorn]

Just FYI this dupes this PR #12980 for the associated issue hashicorp/terraform-provider-google#21254

Thanks for pointing this out and for your contribution - but after reviewing this PR it seems complete and I'd like to move forward with merging. I'll close out your PR but if you feel there's anything else missing please feel free to open another.

[JordanLoehr]

Just FYI this dupes this PR #12980 for the associated issue hashicorp/terraform-provider-google#21254

Thanks for pointing this out and for your contribution - but after reviewing this PR it seems complete and I'd like to move forward with merging. I'll close out your PR but if you feel there's anything else missing please feel free to open another.

All good! All that matters to me is we get the feature in one way or another!

[kautikdk]

Thanks @JordanLoehr and @gurusai-voleti for the efforts!