Skip to content

Add HostProjectRegistration resource in API hub #13092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

edwinfranciss
Copy link
Contributor

@edwinfranciss edwinfranciss commented Feb 17, 2025

As part of API Hub product, added support for the resource HostProjectRegistration (google_apihub_host_project_registration)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_apihub_host_project_registration`

@github-actions github-actions bot requested a review from BBBmau February 17, 2025 16:40
Copy link

github-actions bot commented Feb 17, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 17, 2025
Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@roaks3
Copy link
Contributor

roaks3 commented Feb 20, 2025

@modular-magician reassign-reviewer as the contributor has pinged me that this has some time sensitivity

@roaks3
Copy link
Contributor

roaks3 commented Feb 20, 2025

@modular-magician reassign-reviewer

@github-actions github-actions bot requested a review from roaks3 February 20, 2025 17:35
Copy link

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to run checks to confirm

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 25, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 519 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 519 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_apihub_host_project_registration

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1
Passed tests: 0
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • apihub

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApihubHostProjectRegistration_apihubHostProjectRegistrationBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApihubHostProjectRegistration_apihubHostProjectRegistrationBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@roaks3 roaks3 added this pull request to the merge queue Feb 25, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 36067e8 Feb 25, 2025
22 of 23 checks passed
RooBarsic pushed a commit to RooBarsic/magic-modules that referenced this pull request Feb 27, 2025
maxi-cit pushed a commit to maxi-cit/magic-modules that referenced this pull request Feb 27, 2025
NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Mar 13, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants