Skip to content

Terraform Support for Dataplex Glossary #13095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

Sachin-Rungta
Copy link
Member

@Sachin-Rungta Sachin-Rungta commented Feb 18, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_dataplex_glossary`

@github-actions github-actions bot requested a review from melinath February 18, 2025 05:48
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1625 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 1693 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 476 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 214 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_glossary_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_glossary_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_dataplex_glossary_iam_binding
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]
  • google_dataplex_glossary_iam_member
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]
  • google_dataplex_glossary_iam_policy
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 49
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexGlossary_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossary_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the problem.

@github-actions github-actions bot requested a review from melinath May 12, 2025 19:02
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1625 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 1693 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 476 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 214 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_glossary_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_glossary_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_dataplex_glossary_iam_binding
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]
  • google_dataplex_glossary_iam_member
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]
  • google_dataplex_glossary_iam_policy
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 49
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexGlossary_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossary_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1625 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 1696 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 476 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 214 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_glossary_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_glossary_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_dataplex_glossary_iam_binding
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]
  • google_dataplex_glossary_iam_member
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]
  • google_dataplex_glossary_iam_policy
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 49
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexGlossary_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossary_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from melinath May 13, 2025 04:44
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1625 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 1693 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 476 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 214 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_glossary_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_glossary_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_glossary_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_dataplex_glossary_iam_binding
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]
  • google_dataplex_glossary_iam_member
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]
  • google_dataplex_glossary_iam_policy
    • Expected Document Path: /website/docs/r/dataplex_glossary_iam.html.markdown
    • Fields: [glossary_id]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 49
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexGlossary_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataplexGlossary_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants