Skip to content

Deprecate google_data_catalog_entry #13096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cerberus97
Copy link
Member

@cerberus97 cerberus97 commented Feb 18, 2025

Deprecates google_data_catalog_entry as Data Catalog is being deprecated: https://cloud.google.com/dataplex/docs/transition-to-dataplex-catalog

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

datacatalog: deprecated `google_data_catalog_entry` resource. For steps to transition your Data Catalog users, workloads, and content to Dataplex Catalog, see https://cloud.google.com/dataplex/docs/transition-to-dataplex-catalog.

@github-actions github-actions bot requested a review from NickElliot February 18, 2025 13:47
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+))
google-beta provider: Diff ( 2 files changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 29
Passed tests: 28
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • datacatalog

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+))
google-beta provider: Diff ( 2 files changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 29
Passed tests: 28
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • datacatalog

🟢 All tests passed!

View the build log

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickElliot NickElliot added this pull request to the merge queue Feb 21, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 78755c9 Feb 21, 2025
21 checks passed
NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Mar 13, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants