Fixes issue #21347 related to google_chronicle_rule_deployment resource

[ankitgoyal0301]

Fixes hashicorp/terraform-provider-google#21347

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

chronicle: fixed an error during resource creation with certain `run_frequency` configurations in `google_chronicle_rule_deployment`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 23 insertions(+), 1 deletion(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 23 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• chronicle

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• chronicle

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 24 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• chronicle

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 23 insertions(+))
google-beta provider: Diff ( 3 files changed, 105 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 9 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• chronicle

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccChronicleRuleDeployment_chronicleRuledeploymentRunFrequencyMissingExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccChronicleRuleDeployment_chronicleRuledeploymentRunFrequencyMissingExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[NickElliot]

LGTM, minor change for the redundant comment being removed.

[NickElliot]

Suggested change

// Remove 'run_frequency' from the update mask if it's not configured. (Optional parameter in Terraform.)

[ankitgoyal0301]

Thanks for the review @NickElliot! Kindly review.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 23 insertions(+))
google-beta provider: Diff ( 3 files changed, 103 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 9 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests: 21
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• chronicle

🟢 All tests passed!

View the build log

[NickElliot]

LGTM