-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: compute instance internal ipv6 prefix length is not set in creation and read in syncing #13133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion and read in syncing
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. It looks like at least part of this was added with #8432, and for some reason this field was left out of the flattener/expander. It seems like there may have even been cases where the value of this field wasn't being submitted to the server as expected.
Will run tests and approve once they pass.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1121 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
2fb3859
…ion and read in syncing (GoogleCloudPlatform#13133)
…ion and read in syncing (GoogleCloudPlatform#13133)
…ion and read in syncing (GoogleCloudPlatform#13133)
…ion and read in syncing (GoogleCloudPlatform#13133)
Fixes hashicorp/terraform-provider-google#21520.
This ensures that Terraform correctly reads the
compute_instance.network_interface.internal_ipv6_prefix_length
from GCP and stores it interraform.state
. Previously, the absence of this value interraform.state
causedcompute_instance
to be considered modified, even when no changes were made to the configuration.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.