Skip to content

fix: compute instance internal ipv6 prefix length is not set in creation and read in syncing #13133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

jingjia-peng
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#21520.

This ensures that Terraform correctly reads the compute_instance.network_interface.internal_ipv6_prefix_length from GCP and stores it in terraform.state. Previously, the absence of this value in terraform.state caused compute_instance to be considered modified, even when no changes were made to the configuration.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fix `compute_instance.network_interface.internal_ipv6_prefix_length` not being set or read in Terraform state  

Copy link

google-cla bot commented Feb 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from roaks3 February 20, 2025 19:03
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 20, 2025
Copy link

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. It looks like at least part of this was added with #8432, and for some reason this field was left out of the flattener/expander. It seems like there may have even been cases where the value of this field wasn't being submitted to the server as expected.

Will run tests and approve once they pass.

@modular-magician modular-magician added service/compute-instances and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 27, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 88 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 2 files changed, 88 insertions(+), 22 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+), 44 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1121
Passed tests: 1043
Skipped tests: 77
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstance_internalIPv6PrefixLength

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstance_internalIPv6PrefixLength [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@roaks3 roaks3 added this pull request to the merge queue Feb 27, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 2fb3859 Feb 27, 2025
21 checks passed
NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Mar 13, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_instance.network_interface.internal_ipv6_prefix_length value is not sync with Terraform
3 participants