Skip to content

Fixes issue #21482 related to google_eventarc_trigger name with Firestore sources #13137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

tommyreddad
Copy link
Contributor

@tommyreddad tommyreddad commented Feb 20, 2025

Fixes hashicorp/terraform-provider-google#21482

Also adds acceptance tests for google_eventarc_trigger with Firestore source

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

eventarc: fixed an issue where `google_eventarc_trigger` creation failed due to the region could not be parsed from the trigger's name

@github-actions github-actions bot requested a review from BBBmau February 20, 2025 19:59
Copy link

github-actions bot commented Feb 20, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 96 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 96 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 0
Affected tests: 8

Click here to see the affected service packages
  • eventarc

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccEventarcTrigger_BasicHandWritten
  • TestAccEventarcTrigger_ShortFormWorkflow
  • TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample
  • TestAccEventarcTrigger_eventarcTriggerWithCloudRunDestinationExample
  • TestAccEventarcTrigger_eventarcTriggerWithFirestoreSourceExample
  • TestAccEventarcTrigger_eventarcTriggerWithHttpDestinationExample
  • TestAccEventarcTrigger_eventarcTriggerWithPathPatternFilterExample
  • TestAccEventarcTrigger_eventarcTriggerWithWorkflowDestinationExample

Get to know how VCR tests work

@shuyama1 shuyama1 requested review from shuyama1 and removed request for BBBmau February 20, 2025 20:15
@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccEventarcTrigger_BasicHandWritten [Debug log]
TestAccEventarcTrigger_ShortFormWorkflow [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithCloudRunDestinationExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithFirestoreSourceExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithHttpDestinationExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithPathPatternFilterExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithWorkflowDestinationExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_event_arc_trigger resource errors with 6.21.0
3 participants