Skip to content

Add examples for AlloyDB Major Version Upgrade #13177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 26, 2025

Conversation

GauravJain21
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

alloydb: add examples for AlloyDB Major Version Upgrade for `google_alloydb_cluster` resource.

@github-actions github-actions bot requested a review from slevenick February 25, 2025 12:09
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 256 insertions(+))
google-beta provider: Diff ( 2 files changed, 256 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 290 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 256 insertions(+))
google-beta provider: Diff ( 2 files changed, 256 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 290 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 79
Passed tests: 75
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages
  • alloydb

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbCluster_alloydbClusterAfterUpgradeExample
  • TestAccAlloydbCluster_alloydbClusterBeforeUpgradeExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 79
Passed tests: 75
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages
  • alloydb

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbCluster_alloydbClusterAfterUpgradeExample
  • TestAccAlloydbCluster_alloydbClusterBeforeUpgradeExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccAlloydbCluster_alloydbClusterAfterUpgradeExample [Error message] [Debug log]
TestAccAlloydbCluster_alloydbClusterBeforeUpgradeExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccAlloydbCluster_alloydbClusterAfterUpgradeExample [Error message] [Debug log]
TestAccAlloydbCluster_alloydbClusterBeforeUpgradeExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests aren't being generated with all the right values.

What's the goal here, to show before and after for updating the Postgres version? Is that a difficult upgrade path?

@github-actions github-actions bot requested a review from slevenick February 26, 2025 05:19
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 256 insertions(+))
google-beta provider: Diff ( 2 files changed, 256 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 290 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 256 insertions(+))
google-beta provider: Diff ( 2 files changed, 256 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 290 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 79
Passed tests: 75
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages
  • alloydb

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbCluster_alloydbClusterAfterUpgradeExample
  • TestAccAlloydbCluster_alloydbClusterBeforeUpgradeExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 79
Passed tests: 75
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages
  • alloydb

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbCluster_alloydbClusterAfterUpgradeExample
  • TestAccAlloydbCluster_alloydbClusterBeforeUpgradeExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAlloydbCluster_alloydbClusterAfterUpgradeExample [Debug log]
TestAccAlloydbCluster_alloydbClusterBeforeUpgradeExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAlloydbCluster_alloydbClusterAfterUpgradeExample [Debug log]
TestAccAlloydbCluster_alloydbClusterBeforeUpgradeExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@GauravJain21
Copy link
Contributor Author

Looks like the tests aren't being generated with all the right values.

What's the goal here, to show before and after for updating the Postgres version? Is that a difficult upgrade path?

Fixed the issue. It's a trivial CUJ but it's mandatory to launch this feature in GA.

@slevenick slevenick added this pull request to the merge queue Feb 26, 2025
Merged via the queue into GoogleCloudPlatform:main with commit e98212e Feb 26, 2025
23 checks passed
maxi-cit pushed a commit to maxi-cit/magic-modules that referenced this pull request Feb 27, 2025
NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Mar 13, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants