Skip to content

Add google_eventarc_google_api_source resource #13186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 6, 2025

Conversation

tommyreddad
Copy link
Contributor

Add GoogleApiSource resource for Eventarc.

Release Note Template for Downstream PRs (will be copied)

`google_eventarc_google_api_source`

@github-actions github-actions bot requested a review from melinath February 26, 2025 00:02
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1367 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 7 files changed, 1367 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • eventarc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccEventarcMessageBus

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccEventarcMessageBus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1359 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 7 files changed, 1359 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • eventarc

🟢 All tests passed!

View the build log

Copy link

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great initial PR - thanks! A few change requests below.

@github-actions github-actions bot requested a review from melinath March 5, 2025 01:49
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1399 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 9 files changed, 1399 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 154 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field logging_config.log_severity default value changed from to NONE on google_eventarc_message_bus - reference
  • Field logging_config.log_severity transitioned from optional+computed to optional google_eventarc_message_bus - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • eventarc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccEventarcMessageBus

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1399 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 9 files changed, 1399 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 154 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field logging_config.log_severity default value changed from to NONE on google_eventarc_message_bus - reference
  • Field logging_config.log_severity transitioned from optional+computed to optional google_eventarc_message_bus - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • eventarc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccEventarcMessageBus

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccEventarcMessageBus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccEventarcMessageBus [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1393 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 7 files changed, 1393 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • eventarc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccEventarcMessageBus

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccEventarcMessageBus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1695 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 9 files changed, 1695 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • eventarc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccEventarcGoogleApiSource_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccEventarcGoogleApiSource_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1695 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 9 files changed, 1695 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • eventarc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccEventarcGoogleApiSource_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccEventarcGoogleApiSource_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@tommyreddad tommyreddad marked this pull request as draft March 6, 2025 15:26
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1700 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 9 files changed, 1700 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • eventarc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccEventarcGoogleApiSource_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccEventarcGoogleApiSource_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1700 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 9 files changed, 1700 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • eventarc

🟢 All tests passed!

View the build log

@tommyreddad tommyreddad marked this pull request as ready for review March 6, 2025 17:13
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

key_ring = google_kms_key_ring.keyring.id
}

resource "google_project_service_identity" "eventarc_sa" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test immediately failed in GA, as google_project_service_identity is beta-only. Is there a way to test this without it, or should the update test be beta-only? @tommyreddad @melinath

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, yeah, that's unfortunate. This is a requirement for testing updates to message_bus, so either we don't test updating that field or we don't test updates in GA.

NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Mar 13, 2025
yerniyazN pushed a commit to yerniyazN/magic-modules that referenced this pull request Mar 17, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants