-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add BigQuery BigLake Managed Tables as a Datastream destination #13189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BigQuery BigLake Managed Tables as a Datastream destination #13189
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi @c2thorn, These changes have been tested locally. I can provide the test results privately upon request. |
mmv1/templates/terraform/examples/datastream_stream_bigquery_blmt.tf.tmpl
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 14 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
847bf5b
to
d43e9bc
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 14 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_datastream_stream" "primary" {
destination_config {
bigquery_destination_config {
blmt_config {
bucket = # value needed
connection_name = # value needed
file_format = # value needed
root_path = # value needed
table_format = # value needed
}
}
}
}
|
Tests analyticsTotal tests: 13 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
received test logs offline, LGTM
b3d80d3
Introduce support for BigQuery BigLake Managed Tables as a destination for Datastream streams.
Release Note Template for Downstream PRs (will be copied)