Remove immutable annotation from nodeType to support vertical scaling for redis cluster.

[singh-shreya321]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

redis: added update support for `google_redis_cluster` `node_type`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[slevenick]

Can you add a test that updates this field so we are sure that the update functionality works?

[singh-shreya321]

@slevenick the update is still behind an experiment flag, which will be ramped up soon (in ~1-2 weeks). I will add a test post that if that works. I have tested the functionality locally for allowlisted projects.

[slevenick]

We should only add support for this once it works for everyone. So lets add the test here and wait for rollout before merging

[singh-shreya321]

/gcbrun

[slevenick]

/gcbrun looks like it hit a 500 error on GitHub

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 10 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 22 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 30
Passed tests: 22
Skipped tests: 0
Affected tests: 8

Click here to see the affected service packages

• redis

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_createUpdateClusterWithNodeType
• TestAccRedisCluster_createUpdateDeletionProtection
• TestAccRedisCluster_persistenceUpdate
• TestAccRedisCluster_switchoverAndDetachSecondary
• TestAccRedisCluster_updateClusterEndpoints
• TestAccRedisCluster_updateRedisConfigs
• TestAccRedisCluster_updateReplicaCount
• TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_createUpdateDeletionProtection [Debug log]
TestAccRedisCluster_persistenceUpdate [Debug log]
TestAccRedisCluster_switchoverAndDetachSecondary [Debug log]
TestAccRedisCluster_updateRedisConfigs [Debug log]
TestAccRedisCluster_updateReplicaCount [Debug log]
TestAccRedisCluster_updateShardCount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_createUpdateClusterWithNodeType [Error message] [Debug log]
TestAccRedisCluster_updateClusterEndpoints [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[slevenick]

Looks like update mask is causing issues in the tests

[singh-shreya321]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 10 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 24 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 30
Passed tests: 28
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• redis

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_createUpdateClusterWithNodeType
• TestAccRedisCluster_updateClusterEndpoints

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_createUpdateClusterWithNodeType [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_updateClusterEndpoints [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[slevenick]

Overall good, just want to make sure we aren't deleting this between test steps

[slevenick]

Suggested change

	Config: createOrUpdateRedisCluster(&ClusterParams{name: name, replicaCount: 1, shardCount: 3, deletionProtectionEnabled: false, nodeType: "REDIS_STANDARD_SMALL", zoneDistributionMode: "MULTI_ZONE", maintenanceDay: "TUESDAY", maintenanceHours: 2, maintenanceMinutes: 0, maintenanceSeconds: 0, maintenanceNanos: 0}),
	Config: createOrUpdateRedisCluster(&ClusterParams{name: name, replicaCount: 1, shardCount: 3, deletionProtectionEnabled: true, nodeType: "REDIS_STANDARD_SMALL", zoneDistributionMode: "MULTI_ZONE", maintenanceDay: "TUESDAY", maintenanceHours: 2, maintenanceMinutes: 0, maintenanceSeconds: 0, maintenanceNanos: 0}),

This will make sure it won't get deleted during the next step. Keep it false after the last step to ensure we can actually delete it

[slevenick]

Same here, flip to true

Suggested change

	Config: createOrUpdateRedisCluster(&ClusterParams{name: name, replicaCount: 1, shardCount: 3, deletionProtectionEnabled: false, nodeType: "REDIS_HIGHMEM_MEDIUM", zoneDistributionMode: "MULTI_ZONE", maintenanceDay: "TUESDAY", maintenanceHours: 2, maintenanceMinutes: 0, maintenanceSeconds: 0, maintenanceNanos: 0}),
	Config: createOrUpdateRedisCluster(&ClusterParams{name: name, replicaCount: 1, shardCount: 3, deletionProtectionEnabled: true, nodeType: "REDIS_HIGHMEM_MEDIUM", zoneDistributionMode: "MULTI_ZONE", maintenanceDay: "TUESDAY", maintenanceHours: 2, maintenanceMinutes: 0, maintenanceSeconds: 0, maintenanceNanos: 0}),

[singh-shreya321]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 10 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 23 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 30
Passed tests: 28
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• redis

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_createUpdateClusterWithNodeType
• TestAccRedisCluster_updateClusterEndpoints

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_createUpdateClusterWithNodeType [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_updateClusterEndpoints [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[slevenick]

Thanks! Failing test is unrelated