Adds Datastream connection profile for Salesforce

[matanmggl]

Adds Datastream connection profile for Salesforce.

Release Note Template for Downstream PRs (will be copied)

datastream: added support for creating connection profiles for Salesforce in `google_datastream_connection_profile`. (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 79 insertions(+))
google-beta provider: Diff ( 3 files changed, 431 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 155 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  salesforce_profile {
    domain = # value needed
    oauth2_client_credentials {
      client_id                           = # value needed
      client_secret                       = # value needed
      secret_manager_stored_client_secret = # value needed
    }
    user_credentials {
      password                             = # value needed
      secret_manager_stored_password       = # value needed
      secret_manager_stored_security_token = # value needed
      security_token                       = # value needed
      username                             = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 79 insertions(+))
google-beta provider: Diff ( 3 files changed, 431 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 155 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  salesforce_profile {
    domain = # value needed
    oauth2_client_credentials {
      client_id                           = # value needed
      client_secret                       = # value needed
      secret_manager_stored_client_secret = # value needed
    }
    user_credentials {
      password                             = # value needed
      secret_manager_stored_password       = # value needed
      secret_manager_stored_security_token = # value needed
      security_token                       = # value needed
      username                             = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

waiting for manual test log based on offline discussion

[c2thorn]

manual test run received, LGTM