-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add new resource IAM OAuth Client for Workforce Identity Federation. #13209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
d3ef35c
to
4147dff
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. |
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Tests analyticsTotal tests: 19 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
Tests analyticsTotal tests: 19 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 19 Click here to see the affected service packages
🟢 All tests passed! View the build log |
08e76c9
to
6cc4a7c
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 19 Click here to see the affected service packages
🟢 All tests passed! View the build log |
6cc4a7c
to
421e14d
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Tests analyticsTotal tests: 19 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Note: resource ownership has been added with cl/731773807 |
@roaks3 Do you know why Terraoform-provider-missing-service-labels is failing here? |
I believe cl/731773807 needs times to propagate |
Actually https://github.com/GoogleCloudPlatform/magic-modules/pull/13232/commits is available. I think I just need rebase it and rerun the test. |
421e14d
to
f0f829e
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 19 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Add new resource IAM OAuth Client for Workforce Identity Federation.
Public documentation: https://cloud.google.com/iam/docs/workforce-manage-oauth-app#manage-clients
API: https://cloud.google.com/iam/docs/reference/rest/v1/projects.locations.oauthClients
Fixes hashicorp/terraform-provider-google#20225