Skip to content

Add new resource IAM OAuth Client for Workforce Identity Federation. #13209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

plus-1s
Copy link
Contributor

@plus-1s plus-1s commented Feb 27, 2025

@github-actions github-actions bot requested a review from hao-nan-li February 27, 2025 07:20
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 155 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 221 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_iam_oauth_client

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 155 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 221 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_iam_oauth_client

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 15
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolOauthClient_basic
  • TestAccIAMWorkforcePoolOauthClient_full
  • TestAccIAMWorkforcePoolOauthClient_iamOauthClientBasicExample
  • TestAccIAMWorkforcePoolOauthClient_iamOauthClientFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolOauthClient_basic [Debug log]
TestAccIAMWorkforcePoolOauthClient_full [Debug log]
TestAccIAMWorkforcePoolOauthClient_iamOauthClientBasicExample [Debug log]
TestAccIAMWorkforcePoolOauthClient_iamOauthClientFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iamworkforcepool

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 155 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 221 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iamworkforcepool

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 155 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 221 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iamworkforcepool

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 155 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 221 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_iam_oauth_client

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iamworkforcepool

🟢 All tests passed!

View the build log

@roaks3
Copy link
Contributor

roaks3 commented Feb 27, 2025

Note: resource ownership has been added with cl/731773807

@hao-nan-li
Copy link
Contributor

@roaks3 Do you know why Terraoform-provider-missing-service-labels is failing here?

@plus-1s
Copy link
Contributor Author

plus-1s commented Feb 28, 2025

@roaks3 Do you know why Terraoform-provider-missing-service-labels is failing here?

I believe cl/731773807 needs times to propagate

@github-actions github-actions bot requested a review from hao-nan-li February 28, 2025 23:46
@plus-1s
Copy link
Contributor Author

plus-1s commented Feb 28, 2025

@roaks3 Do you know why Terraoform-provider-missing-service-labels is failing here?

Actually https://github.com/GoogleCloudPlatform/magic-modules/pull/13232/commits is available. I think I just need rebase it and rerun the test.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1195 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 155 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 221 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iamworkforcepool

🟢 All tests passed!

View the build log

@hao-nan-li hao-nan-li added this pull request to the merge queue Mar 1, 2025
Merged via the queue into GoogleCloudPlatform:main with commit fed2c98 Mar 1, 2025
23 checks passed
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Resource projects.location.oauthClient
4 participants