-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add tests for force deletion #13219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for force deletion #13219
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
..._party/terraform/services/firebasedataconnect/resource_firebase_data_connect_service_test.go
Outdated
Show resolved
Hide resolved
mmv1/templates/terraform/examples/firebasedataconnect_service_with_force_deletion.tf.tmpl
Outdated
Show resolved
Hide resolved
2cc8b0c
to
b082e83
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
🟢 All tests passed! View the build log |
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label |
hashicorp/terraform-provider-google#21028
Add tests for force deletion. This was recently supported across all regions in prod.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.