Made nested query resources replace the whole resource instead of merging new over old

[melinath]

This allows fields to be unset using the same logic that any other field on any other resource would use.

Related to hashicorp/terraform-provider-google#14848

b/394945456#comment14

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixed bug in `google_compute_router_nat` where `max_ports_per_vm` couldn't be unset once set.

Note: Technically this also allows nat_ip_allocate_option to be unset, but that field must be set for type = PUBLIC and can't be set for type = PRIVATE, and modifying type forces recreation, so there doesn't seem to be a case where it can actually be unset on update.

This doesn't impact google_compute_router_nat because the only optional field has send_empty_value set.

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRouterNatAddress_withAddressCountDecrease [Error message] [Debug log]
TestAccComputeRouterNatAddress_withNatIpsAndDrainNatIps [Error message] [Debug log]
TestAccComputeRouterNat_withPrivateNatAndRules [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 72 insertions(+), 110 deletions(-))
google-beta provider: Diff ( 3 files changed, 72 insertions(+), 110 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1123
Passed tests: 1040
Skipped tests: 79
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRouterNatAddress_withAddressCountDecrease
• TestAccComputeRouterNatAddress_withNatIpsAndDrainNatIps
• TestAccComputeRouterNat_update
• TestAccComputeRouterNat_withPrivateNatAndRules

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterNat_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeRouterNatAddress_withAddressCountDecrease [Error message] [Debug log]
TestAccComputeRouterNatAddress_withNatIpsAndDrainNatIps [Error message] [Debug log]
TestAccComputeRouterNat_withPrivateNatAndRules [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

this is now covered by the main update test.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 111 insertions(+), 110 deletions(-))
google-beta provider: Diff ( 3 files changed, 112 insertions(+), 110 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1123
Passed tests: 1043
Skipped tests: 79
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRouterNat_withPrivateNatAndRules

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRouterNat_withPrivateNatAndRules [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 77 insertions(+), 108 deletions(-))
google-beta provider: Diff ( 3 files changed, 78 insertions(+), 108 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1123
Passed tests: 1038
Skipped tests: 79
Affected tests: 6

Click here to see the affected service packages

• compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRouterNat_update
• TestAccComputeRouterNat_withAddressCountDecrease
• TestAccComputeRouterNat_withNatIpsAndDrainNatIps
• TestAccComputeRouterNat_withNatRules
• TestAccComputeRouterNat_withPortAllocationMethods
• TestAccComputeRouterNat_withPrivateNatAndRules

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterNat_update [Debug log]
TestAccComputeRouterNat_withAddressCountDecrease [Debug log]
TestAccComputeRouterNat_withNatIpsAndDrainNatIps [Debug log]
TestAccComputeRouterNat_withNatRules [Debug log]
TestAccComputeRouterNat_withPortAllocationMethods [Debug log]
TestAccComputeRouterNat_withPrivateNatAndRules [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[melinath]

@modular-magician reassign-reviewer

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[roaks3]

Nice!