Skip to content

Upgrade DCL to 1.78 #13293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Upgrade DCL to 1.78 #13293

merged 2 commits into from
Mar 13, 2025

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Mar 7, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

clouddeploy: added `dns_endpoint` field to to `google_clouddeploy_target` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@zli82016 zli82016 marked this pull request as ready for review March 7, 2025 19:38
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 21 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 4 files changed, 21 insertions(+), 9 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_target (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_target" "primary" {
  gke {
    dns_endpoint = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 22 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 5 files changed, 22 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4669
Passed tests: 4222
Skipped tests: 436
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccCloudbuildWorkerPool_basic
  • TestAccClouddeployTarget_Target
  • TestAccClouddeployTarget_withAttributionDisabled
  • TestAccClouddeployTarget_withCreationOnlyAttribution
  • TestAccDNSRecordSet_routingPolicy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
  • TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample
  • TestAccSqlUser_password_wo

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4669
Passed tests: 4222
Skipped tests: 436
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccCloudbuildWorkerPool_basic
  • TestAccClouddeployTarget_Target
  • TestAccClouddeployTarget_withAttributionDisabled
  • TestAccClouddeployTarget_withCreationOnlyAttribution
  • TestAccDNSRecordSet_routingPolicy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
  • TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample
  • TestAccSqlUser_password_wo

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccClouddeployTarget_Target [Debug log]
TestAccClouddeployTarget_withAttributionDisabled [Debug log]
TestAccClouddeployTarget_withCreationOnlyAttribution [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccClouddeployTarget_Target [Debug log]
TestAccClouddeployTarget_withAttributionDisabled [Debug log]
TestAccClouddeployTarget_withCreationOnlyAttribution [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4669
Passed tests: 4223
Skipped tests: 436
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudbuildWorkerPool_basic
  • TestAccClouddeployTarget_Target
  • TestAccClouddeployTarget_withAttributionDisabled
  • TestAccClouddeployTarget_withCreationOnlyAttribution
  • TestAccDNSRecordSet_routingPolicy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
  • TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample
  • TestAccSqlUser_password_wo

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 22 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 5 files changed, 22 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccClouddeployTarget_Target [Debug log]
TestAccClouddeployTarget_withAttributionDisabled [Debug log]
TestAccClouddeployTarget_withCreationOnlyAttribution [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4669
Passed tests: 4224
Skipped tests: 436
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudbuildWorkerPool_basic
  • TestAccClouddeployTarget_withAttributionDisabled
  • TestAccClouddeployTarget_withCreationOnlyAttribution
  • TestAccDNSRecordSet_routingPolicy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
  • TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample
  • TestAccSqlUser_password_wo

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccClouddeployTarget_withAttributionDisabled [Debug log]
TestAccClouddeployTarget_withCreationOnlyAttribution [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016 zli82016 requested review from a team and ScottSuarez and removed request for a team March 8, 2025 00:27
@zli82016
Copy link
Member Author

zli82016 commented Mar 8, 2025

Failed tests are unrelated.

@zli82016
Copy link
Member Author

@ScottSuarez , the contributor's hoping this feature can make it into the next release. Could you take a look when you get a chance? Thanks.

@zli82016
Copy link
Member Author

@modular-magician reassign-reviewer

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from melinath March 13, 2025 17:44
@zli82016 zli82016 removed the request for review from ScottSuarez March 13, 2025 17:56
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 added this pull request to the merge queue Mar 13, 2025
Merged via the queue into GoogleCloudPlatform:main with commit cba18c5 Mar 13, 2025
20 of 21 checks passed
yerniyazN pushed a commit to yerniyazN/magic-modules that referenced this pull request Mar 17, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants