Skip to content

Fix issue#20603 #13295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2025
Merged

Fix issue#20603 #13295

merged 3 commits into from
Mar 8, 2025

Conversation

jialei-chen
Copy link
Member

Fixes hashicorp/terraform-provider-google#20603

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

discoveryengine: changed field `dataStoreIds` to mutable in `google_discovery_engine_search_engine`

@github-actions github-actions bot requested a review from trodge March 7, 2025 20:23
Copy link

github-actions bot commented Mar 7, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 31 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 31 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@trodge trodge added this pull request to the merge queue Mar 7, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 184ff95 Mar 8, 2025
22 checks passed
@khuong507
Copy link

Thank you for the fix!

NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Mar 13, 2025
yerniyazN pushed a commit to yerniyazN/magic-modules that referenced this pull request Mar 17, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform updates on Discovery Engine data store ids causes an unexpected delete and recreated
4 participants