Skip to content

Add CreateTime & UpdateTime to google_dataproc_metastore_service #13324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

Noremac201
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#21811

metastore: added `CreateTime` and `UpdateTime` fields to `google_dataproc_metastore_service` resource

@github-actions github-actions bot requested a review from hao-nan-li March 11, 2025 17:26
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/metastore and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 423 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 64 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 21
Skipped tests: 2
Affected tests: 4

Click here to see the affected service packages
  • dataprocmetastore
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMaxScalingFactorExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinAndMaxScalingFactorExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinScalingFactorExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMaxScalingFactorExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinAndMaxScalingFactorExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinScalingFactorExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMaxScalingFactorExample [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinAndMaxScalingFactorExample [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinScalingFactorExample [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 32 insertions(+))
google-beta provider: Diff ( 3 files changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 25
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore

🟢 All tests passed!

View the build log

@hao-nan-li hao-nan-li added this pull request to the merge queue Mar 11, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 0681e00 Mar 11, 2025
22 checks passed
@Noremac201 Noremac201 deleted the serviceFix branch March 11, 2025 22:14
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dataproc Metastore Service Create & Update Times
3 participants