Skip to content

Feature gap: Add workload_policy field #13341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Cezarus27
Copy link
Contributor

@Cezarus27 Cezarus27 commented Mar 12, 2025

This patch adds new field workload_policy.0.type to ResourcePolicy resource.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `workload_policy.type`, `workload_policy.max_topology_distance` and `workload_policy.accelerator_topology` fields to `google_compute_resource_policy` resource

@github-actions github-actions bot requested a review from NickElliot March 12, 2025 15:49
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-instances and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 12, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 30 insertions(+))
google-beta provider: Diff ( 4 files changed, 141 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1138
Passed tests: 1057
Skipped tests: 79
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceTlsSettingsExample
  • TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@Cezarus27 Cezarus27 force-pushed the resource_policy_workload_policy branch from c1be354 to 330ec1a Compare March 13, 2025 11:19
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 13, 2025
@Cezarus27
Copy link
Contributor Author

🟢 Tests passed during RECORDING mode: TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode: TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

This test was added recently. It's not related to the changes in resource policy

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 13, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 30 insertions(+))
google-beta provider: Diff ( 4 files changed, 141 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1138
Passed tests: 1058
Skipped tests: 79
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceTlsSettingsExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 13, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 79 insertions(+))
google-beta provider: Diff ( 4 files changed, 321 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 51 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1140
Passed tests: 1058
Skipped tests: 79
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceTlsSettingsExample
  • TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyAcceleratorTopologyExample
  • TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyMaxTopologyDistanceExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyAcceleratorTopologyExample [Debug log]
TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyMaxTopologyDistanceExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but the conflict needs to be resolved!

@github-actions github-actions bot requested a review from NickElliot March 17, 2025 08:10
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 17, 2025
@Cezarus27
Copy link
Contributor Author

lgtm, but the conflict needs to be resolved!

@NickElliot merge conflict resolved

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 17, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 79 insertions(+))
google-beta provider: Diff ( 4 files changed, 321 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 51 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1143
Passed tests: 1063
Skipped tests: 79
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceTlsSettingsExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@Cezarus27
Copy link
Contributor Author

@NickElliot kind reminder to merge that PR.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickElliot NickElliot added this pull request to the merge queue Mar 20, 2025
Merged via the queue into GoogleCloudPlatform:main with commit a47bdc5 Mar 20, 2025
22 of 23 checks passed
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants