Skip to content

Add DNS_SCOPE_UNSPECIFIED back and fix diffs #13348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Mar 13, 2025

fixes hashicorp/terraform-provider-google#21834

DNS_SCOPE_UNSPECIFIED is removed in PR and caused error when it is specified in the Terraform config. This PR will add it back and suppress the diffs.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: re-added `DNS_SCOPE_UNSPECIFIED` value to the `dns_config.cluster_dns_scope` field in `google_container_cluster` resource and suppressed diffs between `DNS_SCOPE_UNSPECIFIED` in config and empty/null in state

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 47 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 47 insertions(+), 5 deletions(-))

@zli82016
Copy link
Member Author

Tested locally for the following cases:
Create clusters in 6.24.

  • does not specify the field - diffs
  • specifies the unspecified option directly - diffs
  • specifies the implicit default of CLUSTER_SCOPE explicitly

Then tested with this PR and there are no diffs for the first two cases.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 227
Passed tests: 215
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withDNSConfigWithUnspecifiedScope

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withDNSConfigWithUnspecifiedScope [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016 zli82016 marked this pull request as ready for review March 13, 2025 15:19
@zli82016 zli82016 requested a review from rileykarson March 13, 2025 15:37
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 47 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 47 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 227
Passed tests: 216
Skipped tests: 11
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 59 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 59 insertions(+), 6 deletions(-))

2 similar comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 59 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 59 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 59 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 59 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 226
Passed tests: 214
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_cloudDns_nil_scope

Get to know how VCR tests work

2 similar comments
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 226
Passed tests: 214
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_cloudDns_nil_scope

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 226
Passed tests: 214
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_cloudDns_nil_scope

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_cloudDns_nil_scope [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_cloudDns_nil_scope [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_cloudDns_nil_scope [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016 zli82016 requested a review from rileykarson March 13, 2025 19:35
@zli82016
Copy link
Member Author

Modified the tests.

@rileykarson
Copy link
Member

LGTM- edited changelog not slightly to cover the new DSF as well.

@zli82016 zli82016 added this pull request to the merge queue Mar 13, 2025
Merged via the queue into GoogleCloudPlatform:main with commit bdc4748 Mar 13, 2025
24 checks passed
@zli82016 zli82016 deleted the fix-dns-scope branch March 14, 2025 21:23
yerniyazN pushed a commit to yerniyazN/magic-modules that referenced this pull request Mar 17, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_container_cluster docs on DNS_SCOPE_UNSPECIFIED out of date in 6.25.0
3 participants