-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add DNS_SCOPE_UNSPECIFIED back and fix diffs #13348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tested locally for the following cases:
Then tested with this PR and there are no diffs for the first two cases. |
Tests analyticsTotal tests: 227 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 227 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
2 similar comments
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 226 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
2 similar comments
Tests analyticsTotal tests: 226 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 226 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Modified the tests. |
LGTM- edited changelog not slightly to cover the new DSF as well. |
bdc4748
fixes hashicorp/terraform-provider-google#21834
DNS_SCOPE_UNSPECIFIED
is removed in PR and caused error when it is specified in the Terraform config. This PR will add it back and suppress the diffs.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.