Memorystore Valkey Multi vpc support

[NA2047]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_memorystore_instance_desired_user_created_connections`

memorystore: added `psc_attachment_details` field to `google_memorystore_instance` resource, to enable use of the fine-grained resource `google_memorystore_instance_desired_user_created_connections

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1965 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1965 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 466 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_connections (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_connections" "primary" {
  instance_endpoints {
    connections {
      psc_connection {
        address            = # value needed
        forwarding_rule    = # value needed
        network            = # value needed
        project_id         = # value needed
        psc_connection_id  = # value needed
        service_attachment = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_connections

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 4
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

• memorystore

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample
• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updateEngineVersion
• TestAccMemorystoreInstance_updateInstanceEndpoints
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1965 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1965 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 466 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_connections (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_connections" "primary" {
  instance_endpoints {
    connections {
      psc_connection {
        address            = # value needed
        forwarding_rule    = # value needed
        network            = # value needed
        project_id         = # value needed
        psc_connection_id  = # value needed
        service_attachment = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_connections

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample [Error message] [Debug log]
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 4
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

• memorystore

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample
• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updateEngineVersion
• TestAccMemorystoreInstance_updateInstanceEndpoints
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample [Error message] [Debug log]
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1970 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1970 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 466 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_connections (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_connections" "primary" {
  instance_endpoints {
    connections {
      psc_connection {
        address            = # value needed
        forwarding_rule    = # value needed
        network            = # value needed
        project_id         = # value needed
        psc_connection_id  = # value needed
        service_attachment = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_connections

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 10
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• memorystore

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample
• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample
• TestAccMemorystoreInstance_updateInstanceEndpoints

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1968 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1968 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 466 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_connections (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_connections" "primary" {
  instance_endpoints {
    connections {
      psc_connection {
        address            = # value needed
        forwarding_rule    = # value needed
        network            = # value needed
        project_id         = # value needed
        psc_connection_id  = # value needed
        service_attachment = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_connections

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 10
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• memorystore

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample
• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample
• TestAccMemorystoreInstance_updateInstanceEndpoints

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_updateInstanceEndpoints [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample [Error message] [Debug log]
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_updateInstanceEndpoints [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample [Error message] [Debug log]
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1968 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1968 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 466 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_connections (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_connections" "primary" {
  desired_user_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_connections

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 11
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• memorystore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample
• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample [Error message] [Debug log]
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1985 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1985 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 466 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_connections (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_connections" "primary" {
  desired_user_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_connections

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 11
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• memorystore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample
• TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserAndAutoCreatedConnectionsExample [Error message] [Debug log]
TestAccMemorystoreInstanceDesiredUserCreatedConnections_memorystoreInstanceDesiredUserCreatedConnectionsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1986 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1986 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 466 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_connections (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_connections" "primary" {
  desired_user_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_connections

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserCreatedEndpointsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1955 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 9 files changed, 1955 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 460 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_endpoints (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_endpoints" "primary" {
  desired_user_created_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_endpoints

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserCreatedEndpointsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserCreatedEndpointsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[roaks3]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1955 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 9 files changed, 1955 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 460 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_endpoints (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_endpoints" "primary" {
  desired_user_created_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_endpoints

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserCreatedEndpointsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserCreatedEndpointsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

Looks like the test continues to fail due to errors deleting a resource. Can you fix that?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1955 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 9 files changed, 1955 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 460 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_endpoints (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_endpoints" "primary" {
  desired_user_created_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_endpoints

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• memorystore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserAndAutoCreatedEndpointsExample
• TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserCreatedEndpointsExample

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1955 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 9 files changed, 1955 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 460 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_endpoints (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_endpoints" "primary" {
  desired_user_created_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_endpoints

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• memorystore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserAndAutoCreatedEndpointsExample
• TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserCreatedEndpointsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserAndAutoCreatedEndpointsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserCreatedEndpointsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserAndAutoCreatedEndpointsExample [Debug log]
TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserCreatedEndpointsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test