Skip to content

Added pod_autoscaling field to google_container_cluster resource #13359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2025

Conversation

mjogdand
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#21727

container: added `pod_autoscaling` field to `google_container_cluster` resource

@github-actions github-actions bot requested a review from slevenick March 14, 2025 16:30
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 14, 2025
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 14, 2025
@mjogdand
Copy link
Contributor Author

@slevenick - I have executed the impacted test locally, and it passed.

image

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 12 insertions(+))
google-beta provider: Diff ( 3 files changed, 172 insertions(+))

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 14, 2025
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 227
Passed tests: 215
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withPodAutoscaling

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withPodAutoscaling [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 14, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 11 insertions(+))
google-beta provider: Diff ( 3 files changed, 170 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 227
Passed tests: 215
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withPodAutoscaling

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withPodAutoscaling [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@mjogdand
Copy link
Contributor Author

@slevenick - All checks are passed, Can you please review and approve the PR?

@mjogdand
Copy link
Contributor Author

@slevenick - Sorry to trouble you again, can you please review and approve the PR?,

@github-actions github-actions bot requested a review from slevenick March 17, 2025 17:56
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 17, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 11 insertions(+))
google-beta provider: Diff ( 3 files changed, 159 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 228
Passed tests: 216
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withPodAutoscaling

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withPodAutoscaling [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@mjogdand
Copy link
Contributor Author

Hello @slevenick

Updated the code as per your feedback, do you think any additional changes are required or change is good to go ahead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for enabling Performance HPA Profile for clusters
3 participants