-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added pod_autoscaling field to google_container_cluster resource #13359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster.go.tmpl
Outdated
Show resolved
Hide resolved
@slevenick - I have executed the impacted test locally, and it passed. |
Tests analyticsTotal tests: 227 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 227 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
@slevenick - All checks are passed, Can you please review and approve the PR? |
@slevenick - Sorry to trouble you again, can you please review and approve the PR?, |
mmv1/third_party/terraform/services/container/resource_container_cluster.go.tmpl
Outdated
Show resolved
Hide resolved
Tests analyticsTotal tests: 228 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hello @slevenick Updated the code as per your feedback, do you think any additional changes are required or change is good to go ahead? |
855e895
Fixes hashicorp/terraform-provider-google#21727