Fixed not being able to update preview status in SecurityPolicyRule and RegionSecurityPolicyRule

[matheusaleixo-cit]

Fixes not being able to update the field preview from true to false in google_compute_security_policy_rule and google_compute_region_security_policy_rule, causing a permadiff.

Fixes: #19443, #20949

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixed unable to update the `preview` field for `google_compute_security_policy_rule` resource

compute: fixed unable to update the `preview` field for `google_compute_region_security_policy_rule` resource (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 10 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 20 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1139
Passed tests: 1045
Skipped tests: 79
Affected tests: 15

Click here to see the affected service packages

• compute

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionSecurityPolicyRule_EnforceOnKeyUpdates
• TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleBasicUpdate
• TestAccComputeRegionSecurityPolicyRule_securityPolicyDefaultRule
• TestAccComputeRegionSecurityPolicyRule_withPreconfiguredWafConfig
• TestAccComputeRegionSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs
• TestAccComputeRegionSecurityPolicyRule_withRateLimitOptions
• TestAccComputeRegionSecurityPolicyRule_withRuleExpr
• TestAccComputeSecurityPolicyRule_EnforceOnKeyUpdates
• TestAccComputeSecurityPolicyRule_basicUpdate
• TestAccComputeSecurityPolicyRule_securityPolicyDefaultRule
• TestAccComputeSecurityPolicyRule_withHeadAction
• TestAccComputeSecurityPolicyRule_withPreconfiguredWafConfig
• TestAccComputeSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs
• TestAccComputeSecurityPolicyRule_withRateLimitOptions
• TestAccComputeSecurityPolicyRule_withRedirectOptionsUpdate

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionSecurityPolicyRule_EnforceOnKeyUpdates [Debug log]
TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleBasicUpdate [Debug log]
TestAccComputeRegionSecurityPolicyRule_securityPolicyDefaultRule [Debug log]
TestAccComputeRegionSecurityPolicyRule_withPreconfiguredWafConfig [Debug log]
TestAccComputeRegionSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs [Debug log]
TestAccComputeRegionSecurityPolicyRule_withRateLimitOptions [Debug log]
TestAccComputeRegionSecurityPolicyRule_withRuleExpr [Debug log]
TestAccComputeSecurityPolicyRule_EnforceOnKeyUpdates [Debug log]
TestAccComputeSecurityPolicyRule_basicUpdate [Debug log]
TestAccComputeSecurityPolicyRule_securityPolicyDefaultRule [Debug log]
TestAccComputeSecurityPolicyRule_withHeadAction [Debug log]
TestAccComputeSecurityPolicyRule_withPreconfiguredWafConfig [Debug log]
TestAccComputeSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs [Debug log]
TestAccComputeSecurityPolicyRule_withRateLimitOptions [Debug log]
TestAccComputeSecurityPolicyRule_withRedirectOptionsUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[shuyama1]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 10 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 20 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1145
Passed tests: 1061
Skipped tests: 79
Affected tests: 5

Click here to see the affected service packages

• compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceFromMachineImage_terminationTime
• TestAccComputeInstanceFromTemplate_TerminationTime
• TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime
• TestAccComputeInstance_schedulingTerminationTime
• TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceFromMachineImage_terminationTime [Debug log]
TestAccComputeInstanceFromTemplate_TerminationTime [Debug log]
TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccComputeInstance_schedulingTerminationTime [Debug log]
TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test