-
Notifications
You must be signed in to change notification settings - Fork 1.8k
add ip_endpoints_config field to google_container_cluster #13364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ip_endpoints_config field to google_container_cluster #13364
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
CheckDestroy: testAccCheckContainerClusterDestroyProducer(t), | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccContainerCluster_basic(clusterName, networkName, subnetworkName), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm understanding correctly, testAccContainerCluster_basic
will have the new field as enabled true
by default, and the update will disable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming yes according to the documentation
@translucens can you join https://github.com/GoogleCloudPlatform and set the visibility to public? If so, you will get automatic build runs on our repository |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 229 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
waiting to merge after some downstream issues have been resolved |
391211e
Fixes hashicorp/terraform-provider-google#20369
Release Note Template for Downstream PRs (will be copied)