Skip to content

Add locations field to mirroring deployment group. #13367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

duvni
Copy link
Contributor

@duvni duvni commented Mar 17, 2025

Add the new locations output field to Mirroring Deployment Group resource.
Used to expose the locations where the deployment group is currently deployed.

networksecurity: added `locations` field to `google_network_security_mirroring_deployment_group` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 78 insertions(+))
google-beta provider: Diff ( 3 files changed, 78 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 61
Passed tests: 57
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages
  • networksecurity

🟢 All tests passed!

View the build log

@duvni duvni marked this pull request as ready for review March 17, 2025 10:04
@github-actions github-actions bot requested a review from BBBmau March 17, 2025 10:05
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@BBBmau BBBmau added this pull request to the merge queue Mar 21, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 91c7e1c Mar 21, 2025
22 checks passed
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
@duvni duvni deleted the pm2-dg branch April 21, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants