Skip to content

feat: (storagetransfer) add metadata_options in transfer spec #13371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2025

Conversation

gurusai-voleti
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#11949
Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: added metadata_options in transfer_spec

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 468 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 479 insertions(+), 30 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field transfer_spec.azure_blob_storage_data_source.azure_credentials changed from optional to required on google_storage_transfer_job - reference
  • Field transfer_spec.azure_blob_storage_data_source.credentials_secret within resource google_storage_transfer_job was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • storagetransfer

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageTransferJob_metadataOptions

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageTransferJob_metadataOptions [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 491 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 2 files changed, 480 insertions(+), 22 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 491 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 2 files changed, 480 insertions(+), 22 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storagetransfer
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccStorageTransferJob_metadataOptions
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storagetransfer
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccStorageTransferJob_metadataOptions
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 463 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 463 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storagetransfer
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccStorageTransferJob_metadataOptions
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 461 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 461 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storagetransfer
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccStorageTransferJob_metadataOptions
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 463 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 463 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • storagetransfer

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageTransferReplicationJob_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@gurusai-voleti gurusai-voleti marked this pull request as ready for review March 17, 2025 13:42
@github-actions github-actions bot requested a review from trodge March 17, 2025 13:44
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@trodge trodge added this pull request to the merge queue Mar 17, 2025
Merged via the queue into GoogleCloudPlatform:main with commit a882d62 Mar 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata_options not provided in transfer_spec for Google Storage Transfer Service
3 participants