Skip to content

Add connectedDeploymentGroups and associations fields to mirroring endpoint group. #13372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

duvni
Copy link
Contributor

@duvni duvni commented Mar 17, 2025

Add the new connectedDeploymentGroups and associations output fields to Mirroring Endpoint Group resource.
These fields expose to the user more data on the connected deployment groups and the associated networks.

networksecurity: added `connectedDeploymentGroups` and `associations` fields to `google_network_security_mirroring_endpoint_group` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 287 insertions(+))
google-beta provider: Diff ( 3 files changed, 287 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • networksecurity

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 248 insertions(+))
google-beta provider: Diff ( 3 files changed, 248 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 61
Passed tests: 57
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages
  • networksecurity

🟢 All tests passed!

View the build log

@duvni duvni marked this pull request as ready for review March 17, 2025 11:46
@github-actions github-actions bot requested a review from BBBmau March 17, 2025 11:47
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants