Revert "Add bac to backend service"

[porky256]

compute: remove tlsSettings from `google_compute_backend_service` (revert)

Reverts #13213
Causing hashicorp/terraform-provider-google#21884, and can't be fixed at the moment because of the blockers on the GCP side.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 339 deletions(-))
google-beta provider: Diff ( 4 files changed, 339 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 84 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field tls_settings.authentication_config within resource google_compute_backend_service was either removed or renamed - reference
• Field tls_settings.sni within resource google_compute_backend_service was either removed or renamed - reference
• Field tls_settings.subject_alt_names.dns_name within resource google_compute_backend_service was either removed or renamed - reference
• Field tls_settings.subject_alt_names.uniform_resource_identifier within resource google_compute_backend_service was either removed or renamed - reference
• Field tls_settings.subject_alt_names within resource google_compute_backend_service was either removed or renamed - reference
• Field tls_settings within resource google_compute_backend_service was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[porky256]

No customers is using this feature yet, so it's not a breaking change.

[modular-magician]

Tests analytics

Total tests: 1139
Passed tests: 1060
Skipped tests: 79
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[zli82016]

LGTM

authentication_config field depends on google_network_security_backend_authentication_config resource, which is only available in beta

The test TestAccComputeBackendService_backendServiceTlsSettingsExample also failed in nightly beta.

------- Stdout: -------
=== RUN   TestAccComputeBackendService_backendServiceTlsSettingsExample
=== PAUSE TestAccComputeBackendService_backendServiceTlsSettingsExample
=== CONT  TestAccComputeBackendService_backendServiceTlsSettingsExample
    resource_compute_backend_service_generated_test.go:752: Step 1/2 error: Error running pre-apply refresh: exit status 1
        Error: Unsupported argument
          on terraform_plugin_test.tf line 9, in resource "google_compute_backend_service" "default":
           9:     subjectAltNames = [
        An argument named "subjectAltNames" is not expected here.
        Error: Incorrect attribute value type
          on terraform_plugin_test.tf line 17, in resource "google_compute_backend_service" "default":
          17:     authentication_config = [google_network_security_backend_authentication_config.default.id]
        Inappropriate value for attribute "authentication_config": string required.
--- FAIL: TestAccComputeBackendService_backendServiceTlsSettingsExample (0.50s)
FAIL

[zli82016]

I tested it locally, and the field does't work at all with the error

Invalid value for field 'resource.tlsSettings':
Tls Settings are not supported for global EXTERNAL backend services

[porky256]

Yep, that is the reason why I want to roll this changes back. Once error you see will be fixed, I’ll open a new pr with this changes. Thanks for reviewing this!