Memorystore Instance Cross Instance Replication addition

[NA2047]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

memorystore: added the `cross_cluster_replication_config` field to the `google_redis_cluster` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1052 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 5 files changed, 1052 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 11
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• memorystore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample
• TestAccMemorystoreInstance_switchoverAndDetachSecondary

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Error message] [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1055 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 5 files changed, 1055 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 4
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

• memorystore

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample
• TestAccMemorystoreInstance_switchoverAndDetachSecondary
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updateEngineVersion
• TestAccMemorystoreInstance_updateNodeType
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Debug log]
TestAccMemorystoreInstance_updateNodeType [Debug log]
TestAccMemorystoreInstance_updatePersistence [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Debug log]
TestAccMemorystoreInstance_updateShardCount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[trodge]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1055 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 5 files changed, 1055 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1059 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 5 files changed, 1059 insertions(+), 19 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_updateInstanceEndpoints

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1056 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 5 files changed, 1056 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample
• TestAccMemorystoreInstance_switchoverAndDetachSecondary
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[NickElliot]

looks like an issue from the merge

github.com/hashicorp/terraform-provider-google-beta/google-beta/services/memorystore_test [github.com/hashicorp/terraform-provider-google-beta/google-beta/services/memorystore.test]
google-beta/services/memorystore/resource_memorystore_instance_test.go:870: undefined: userEndpointsBlock

is this recurring locally?

in interest of a faster review can you rerun it locally after fixing/before pushing to verify theres no critical build failure beforehand?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1056 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 5 files changed, 1056 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1062 insertions(+), 23 deletions(-))
google-beta provider: Diff ( 5 files changed, 1062 insertions(+), 23 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 7
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

• memorystore

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_switchoverAndDetachSecondary
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updateEngineVersion
• TestAccMemorystoreInstance_updateInstanceEndpoints
• TestAccMemorystoreInstance_updateNodeType
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1056 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 5 files changed, 1054 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_updateInstanceEndpoints

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_updateInstanceEndpoints [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1063 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 5 files changed, 1063 insertions(+), 24 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 7
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

• memorystore

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_switchoverAndDetachSecondary
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updateEngineVersion
• TestAccMemorystoreInstance_updateInstanceEndpoints
• TestAccMemorystoreInstance_updateNodeType
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1056 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 5 files changed, 1056 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 7
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

• memorystore

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_switchoverAndDetachSecondary
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updateEngineVersion
• TestAccMemorystoreInstance_updateInstanceEndpoints
• TestAccMemorystoreInstance_updateNodeType
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1053 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 5 files changed, 1053 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 229 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 232 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  cross_instance_replication_config {
    secondary_instances {
      instance = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

🟢 All tests passed!

View the build log

[NickElliot]

LGTM!