Add Terraform support for antivirus threat override

[maxi-cit]

Release Note Template for Downstream PRs (will be copied)

networksecurity: added `antivirus_overrides` field to `google_network_security_security_profile.threat_prevention_profile` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[maxi-cit]

Hello @melinath could you run tests and check if everything is ok with the PR, please?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 195 insertions(+))
google-beta provider: Diff ( 5 files changed, 195 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))

[modular-magician]

Tests analytics

Total tests: 62
Passed tests: 56
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

• networksecurity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileOverridesExample
• TestAccNetworkSecuritySecurityProfiles_antivirusOverrides

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileOverridesExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccNetworkSecuritySecurityProfiles_antivirusOverrides [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

Error:

    resource_network_security_security_profile_test.go:53: Step 3/4 error: Error running pre-apply refresh: exit status 1
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 14, in resource "google_network_security_security_profile" "foobar":
          14:         antivirus_overrides {
        
        The argument "protocol" is required, but no definition was found.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 16, in resource "google_network_security_security_profile" "foobar":
          16:             severity = "FTP"
        
        An argument named "severity" is not expected here.
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 19, in resource "google_network_security_security_profile" "foobar":
          19:         antivirus_overrides {
        
        The argument "protocol" is required, but no definition was found.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 21, in resource "google_network_security_security_profile" "foobar":
          21:             severity = "HTTP"
        
        An argument named "severity" is not expected here.
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 24, in resource "google_network_security_security_profile" "foobar":
          24: 		antivirus_overrides {
        
        The argument "protocol" is required, but no definition was found.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 26, in resource "google_network_security_security_profile" "foobar":
          26:             severity = "HTTP2"
        
        An argument named "severity" is not expected here.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 195 insertions(+))
google-beta provider: Diff ( 5 files changed, 195 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))

[modular-magician]

Tests analytics

Total tests: 62
Passed tests: 57
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

• networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecuritySecurityProfiles_antivirusOverrides

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecuritySecurityProfiles_antivirusOverrides [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[maxi-cit]

Hello @melinath checks seem to be ok, do you think this is ready to merge?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 214 insertions(+))
google-beta provider: Diff ( 5 files changed, 214 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• networksecurity

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccNetworkSecuritySecurityProfiles_antivirusOverrides
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 215 insertions(+))
google-beta provider: Diff ( 5 files changed, 215 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))

[modular-magician]

Tests analytics

Total tests: 62
Passed tests: 57
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

• networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecuritySecurityProfiles_antivirusOverrides

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecuritySecurityProfiles_antivirusOverrides [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[maxi-cit]

Hello @melinath, I just saw your suggestions. Thanks for the feedback and commit. I will take them into account for next PRs.