Skip to content

Add Dataproc Metastore Table Resource for IAM support #13446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

Noremac201
Copy link
Contributor

@Noremac201 Noremac201 commented Mar 24, 2025

Fixes hashicorp/terraform-provider-google#21823

This resource is only meant for IAM usage, as it doesn't really "exist" in GCP. The "database" and "table" resource cannot be created via terraform directly, so the example configuration required a custom yaml.tmpl for testing that creates the resources via a Dataproc Job.

Tested via running acctest with personal credentials.

`google_dataproc_metastore_table_iam_member`
`google_dataproc_metastore_table_iam_policy`
`google_dataproc_metastore_table_iam_binding`

@github-actions github-actions bot requested a review from shuyama1 March 24, 2025 18:28
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1025 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1025 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 414 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_metastore_table_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_metastore_table_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataproc_metastore_table_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_metastore_table_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 33
Passed tests: 28
Skipped tests: 2
Affected tests: 3

Click here to see the affected service packages
  • dataprocmetastore

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocMetastoreTableIamBindingGenerated
  • TestAccDataprocMetastoreTableIamMemberGenerated
  • TestAccDataprocMetastoreTableIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocMetastoreTableIamBindingGenerated [Debug log]
TestAccDataprocMetastoreTableIamMemberGenerated [Debug log]
TestAccDataprocMetastoreTableIamPolicyGenerated [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Dataproc Metastore Table IAM via TF
3 participants