Skip to content

feat: (storage) added md5hexhash field in storage object #13464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

gurusai-voleti
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#3888
Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: added md5hexhash field in storage object

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 22 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 22 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 120
Passed tests: 110
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • storage

🟢 All tests passed!

View the build log

@gurusai-voleti gurusai-voleti marked this pull request as ready for review March 27, 2025 13:41
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge March 27, 2025 13:42
Copy link
Member

@kautikdk kautikdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check if there is a way to achieve similar results by Terraform functions or specific providers like mentioned in this comment: hashicorp/terraform-provider-google#3888 (comment) ?
If there is, I don't think we have to introduce a new field just for a specific use case.

Copy link

github-actions bot commented Apr 1, 2025

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@gurusai-voleti
Copy link
Contributor Author

Can you please check if there is a way to achieve similar results by Terraform functions or specific providers like mentioned in this comment: hashicorp/terraform-provider-google#3888 (comment) ? If there is, I don't think we have to introduce a new field just for a specific use case.

I see there is no builtin function for this

Copy link

github-actions bot commented Apr 3, 2025

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@trodge trodge added this pull request to the merge queue Apr 4, 2025
Merged via the queue into GoogleCloudPlatform:main with commit be65ab7 Apr 4, 2025
21 checks passed
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
pandirigoog pushed a commit to pandirigoog/magic-modules that referenced this pull request Apr 14, 2025
shantstepanian pushed a commit to shantstepanian/magic-modules that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functionality to provide hexadecimal hash of the object inside google cloud bucket
4 participants