-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: (storage) added md5hexhash field in storage object #13464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 120 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please check if there is a way to achieve similar results by Terraform functions or specific providers like mentioned in this comment: hashicorp/terraform-provider-google#3888 (comment) ?
If there is, I don't think we have to introduce a new field just for a specific use case.
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
I see there is no builtin function for this |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label |
Fixes: hashicorp/terraform-provider-google#3888
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.