Skip to content

Add deletion_protection field to Metastore Federation #13471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rajeshgupthar
Copy link
Contributor

@rajeshgupthar rajeshgupthar commented Mar 27, 2025

Add deletion_protection field to make deletion actions require an explicit intent
Part of b/366209903
Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

metastore: added `deletion_protection` field to `google_dataproc_metastore_federation`

@github-actions github-actions bot requested a review from slevenick March 27, 2025 06:27
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 136 insertions(+), 227 deletions(-))
google-beta provider: Diff ( 7 files changed, 135 insertions(+), 227 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 34
Passed tests: 31
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • dataprocmetastore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccMetastoreFederation_deletionprotection

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccMetastoreFederation_deletionprotection [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from slevenick March 28, 2025 10:21
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 137 insertions(+), 227 deletions(-))
google-beta provider: Diff ( 7 files changed, 137 insertions(+), 227 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 34
Passed tests: 32
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants