Skip to content

Add md5authenticationkeys to google_compute_router #13472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

karolgorc
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Added `md5_authentication_keys` to `google_compute_router`

@github-actions github-actions bot requested a review from BBBmau March 27, 2025 08:12
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-router and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 27, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 141 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 141 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 125 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1158
Passed tests: 1078
Skipped tests: 79
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_computeRouterMd5encryptedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRouter_computeRouterMd5encryptedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants