Set a default value for envs in Cloud Run Job

[oliver-hohn]

What?

• Make a similar change to Add default value to env.value to fix the plan diffs in cloud run services #13363 but for the google_cloud_run_v2_job resource.
  • Fixes Cloud Run env variables reordering causing resource to update in-place hashicorp/terraform-provider-google#7467
  • Fixes Cloud Run it's recreating all the secret environment variables when adding/removing a secret env hashicorp/terraform-provider-google#10634

Why?

• Currently, when a new env variable is added to the env set, the env set is re-ordered which results in a large diff, see Cloud Run env variables reordering causing resource to update in-place hashicorp/terraform-provider-google#7467 for an example. The cause for this seems to be that in the Terraform state the env value is "" when using a value_source (i.e. a reference to a google_secret_manager_secret), but in the plan the value is nil (as it has not been set), which then triggers all of the envs to have changed.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudrunv2: fixed the diffs for unchanged `template.template.containers.env` in `google_cloud_run_v2_job` resource

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[ScottSuarez]

waiting for integration tests

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field template.template.containers.env.value default value changed from to on google_cloud_run_v2_job - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 51
Passed tests: 46
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages

• cloudrunv2

🟢 All tests passed!

View the build log