Skip to content

Adding Redis cluster import sources #13550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 8, 2025

Conversation

NA2047
Copy link
Contributor

@NA2047 NA2047 commented Apr 4, 2025

redis: added `managed_backup_source` and ` gcs_source` fields to `google_redis_cluster` resource

@NA2047 NA2047 marked this pull request as draft April 4, 2025 17:05
@github-actions github-actions bot requested a review from zli82016 April 4, 2025 17:06
Copy link

github-actions bot commented Apr 4, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 611 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 666 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 58 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  gcs_source {
    uris = # value needed
  }
  managed_backup_source {
    backup = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • redis
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccRedisCluster_gcsSource
  • TestAccRedisCluster_managedBackupSource
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 611 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 666 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 58 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  gcs_source {
    uris = # value needed
  }
  managed_backup_source {
    backup = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • redis
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccRedisCluster_gcsSource
  • TestAccRedisCluster_managedBackupSource
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 611 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 611 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 58 insertions(+))

@NA2047 NA2047 force-pushed the RedisImportSource_test branch from b5af6cc to df630df Compare April 4, 2025 20:28
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 611 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 609 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 58 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • redis

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_gcsSource
  • TestAccRedisCluster_managedBackupSource

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_managedBackupSource [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_gcsSource [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 547 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 545 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 58 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 33
Passed tests: 32
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_gcsSource

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_gcsSource [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@NA2047 NA2047 marked this pull request as ready for review April 5, 2025 04:42
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 540 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 538 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 58 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 33
Passed tests: 33
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • redis

🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from zli82016 April 8, 2025 21:52
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 536 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 534 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 58 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 33
Passed tests: 32
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_gcsSource

Get to know how VCR tests work

@NA2047 NA2047 force-pushed the RedisImportSource_test branch from 75f75a7 to eadd6c3 Compare April 8, 2025 22:07
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 536 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 534 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 58 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 33
Passed tests: 32
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_gcsSource

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_gcsSource [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_gcsSource [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 changed the title Adding Redis import sources Adding Redis cluster import sources Apr 8, 2025
@zli82016 zli82016 added this pull request to the merge queue Apr 8, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 74e5612 Apr 8, 2025
24 checks passed
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
pandirigoog pushed a commit to pandirigoog/magic-modules that referenced this pull request Apr 14, 2025
shantstepanian pushed a commit to shantstepanian/magic-modules that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants