Clarify recommendation for simple map types #13551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roaks3
requested review from
a team and
rileykarson
and removed request for
a team
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
@modular-magician reassign-reviewer |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@modular-magician reassign-reviewer |
github-actions
bot
requested review from
BBBmau
and removed request for
rileykarson
|
@modular-magician reassign-reviewer |
trodge
approved these changes
Apr 8, 2025
Dawid212
pushed a commit
to Dawid212/magic-modules
that referenced
this pull request
Apr 9, 2025
pandirigoog
pushed a commit
to pandirigoog/magic-modules
that referenced
this pull request
Apr 14, 2025
shantstepanian
pushed a commit
to shantstepanian/magic-modules
that referenced
this pull request
Apr 21, 2025
NandiniAgrawal15
pushed a commit
to NandiniAgrawal15/magic-modules
that referenced
this pull request
Apr 26, 2025
NandiniAgrawal15
pushed a commit
to NandiniAgrawal15/magic-modules
that referenced
this pull request
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/385136052
KeyValuePairsis strictly defined to mean string -> string, so for other simple map types like string -> int, we will recommend the Map type.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.