Skip to content

Allow setting SSL type on connection profiles #13559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

owaismawasy
Copy link
Contributor

@owaismawasy owaismawasy commented Apr 7, 2025

Cloud DMS API & UI started to support setting the SSL type on source connection profiles. This change allows setting the SSL type in the Terraform templates.

databasemigrationservice: added `ssl.type` as an input field to `google_database_migration_service_connection_profile` resource

Copy link

github-actions bot commented Apr 7, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 24 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 6 files changed, 24 insertions(+), 8 deletions(-))
Open in Cloud Shell: Diff ( 5 files changed, 5 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 6
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages
  • databasemigrationservice

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample
  • TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample
  • TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobMysqlToMysqlExample
  • TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToAlloydbExample
  • TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresExample
  • TestAccDatabaseMigrationServiceMigrationJob_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample [Debug log]
TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobMysqlToMysqlExample [Debug log]
TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToAlloydbExample [Debug log]
TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresExample [Debug log]
TestAccDatabaseMigrationServiceMigrationJob_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to test one of the added enum values here?
For example type = "required" in any existing test?

@github-actions github-actions bot requested a review from hao-nan-li April 8, 2025 12:41
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 24 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 6 files changed, 24 insertions(+), 8 deletions(-))
Open in Cloud Shell: Diff ( 13 files changed, 295 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • databasemigrationservice

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresNoSslExample
  • TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresRequiredSslExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 292 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 6 files changed, 292 insertions(+), 20 deletions(-))
Open in Cloud Shell: Diff ( 13 files changed, 295 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_database_migration_service_connection_profile (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_database_migration_service_connection_profile" "primary" {
  oracle {
    ssl {
      ca_certificate = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • databasemigrationservice

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresNoSslExample
  • TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresRequiredSslExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresNoSslExample [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresRequiredSslExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresNoSslExample [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresRequiredSslExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@hao-nan-li hao-nan-li added this pull request to the merge queue Apr 8, 2025
Merged via the queue into GoogleCloudPlatform:main with commit e40e832 Apr 8, 2025
23 of 24 checks passed
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
pandirigoog pushed a commit to pandirigoog/magic-modules that referenced this pull request Apr 14, 2025
shantstepanian pushed a commit to shantstepanian/magic-modules that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants