Skip to content

Add new Firestore index and database options #13600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Apr 9, 2025

Release Note Template for Downstream PRs (will be copied)

firestore: added `density` and `multikey` fields to `google_firestore_index` resource
firestore: added `MONGODB_COMPATIBLE_API` enum option to `apiScope` field of `google_firestore_index` resource
firestore: added `databaseEdition` field to `google_firestore_database` resource

@github-actions github-actions bot requested a review from trodge April 9, 2025 12:05
Copy link

github-actions bot commented Apr 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 348 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 8 files changed, 348 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 30 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 21
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • firestore

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreDatabase_firestoreDatabaseEnterpriseExample
  • TestAccFirestoreIndex_firestoreIndexDatastoreModeExample
  • TestAccFirestoreIndex_firestoreIndexMongodbCompatibleScopeExample
  • TestAccFirestoreIndex_firestoreIndexSparseAnyExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseEnterpriseExample [Debug log]
TestAccFirestoreIndex_firestoreIndexDatastoreModeExample [Debug log]
TestAccFirestoreIndex_firestoreIndexMongodbCompatibleScopeExample [Debug log]
TestAccFirestoreIndex_firestoreIndexSparseAnyExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Contributor

@pcostell pcostell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trodge trodge added this pull request to the merge queue Apr 10, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 3275fb5 Apr 10, 2025
23 checks passed
@rwhogg rwhogg deleted the fs-new-index-and-db-options branch April 10, 2025 14:17
pandirigoog pushed a commit to pandirigoog/magic-modules that referenced this pull request Apr 14, 2025
shantstepanian pushed a commit to shantstepanian/magic-modules that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants