-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add a license check for new files #13806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @melinath, just want to confirm with you if this change addresses what's asked in hashicorp/terraform-provider-google#20127
This license text validation is currently implemented to check files in the mmv1 folder. We'd like to confirm if this is the desired scope, or should it be broader?
Also, the ticket description mentions "We should automate validation of its presence and correctness". Could you please clarify what specific aspects of correctness
this should be validating?
Correctness:
Which files: Basically, any files that correspond to other files that currently have it. MMv1 yaml, definitely. tpgtools we can ignore for now because it's not getting new stuff added. I'm not sure if there are other files. We should only be running this check for files modified in the current PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
The current code is checking only the mmv1 folder for .tmpl, .go, .yaml files, and only for new files. If checking for just modified files, then many files will need a touch for the copyright year. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
hashicorp/terraform-provider-google#20127
Tested in #13805.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.