fix: bigtable - avoid instance recreation due to node_scaling_factor addition in 6.34.0 for existing clusters

[shantstepanian]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigtable: fixed forced instance recreation due to addition of `cluster.node_scaling_factor` for `google_bigtable_instance` in 6.34.0

Compatibility testing was executed manually to verify successful upgrades for instances created in 6.33.0 and 6.34.0

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[hao-nan-li]

b/416770785

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Tests analytics

Total tests: 58
Passed tests: 0
Skipped tests: 58
Affected tests: 0

Click here to see the affected service packages

• bigtable

🟢 All tests passed!

View the build log

[zli82016]

The unit test failed

 --- FAIL: TestUnitBigtable_flattenBigtableCluster (0.00s)
    resource_bigtable_instance_internal_test.go:200: bad: SSD auto scaling, got map["autoscaling_config":[map["cpu_target":'2' "max_nodes":'\a' "min_nodes":'\x03' "storage_target":'<']] "cluster_id":"ssd-cluster" "kms_key_name":"KMS" "node_scaling_factor":"NodeScalingFactor1X" "num_nodes":'\x05' "state":"CREATING" "storage_type":"SSD" "zone":"zone1"], want map["autoscaling_config":[map["cpu_target":'2' "max_nodes":'\a' "min_nodes":'\x03' "storage_target":'<']] "cluster_id":"ssd-cluster" "kms_key_name":"KMS" "node_scaling_factor":"" "num_nodes":'\x05' "state":"CREATING" "storage_type":"SSD" "zone":"zone1"]

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 58
Passed tests: 0
Skipped tests: 58
Affected tests: 0

Click here to see the affected service packages

• bigtable

🟢 All tests passed!

View the build log