Skip to content

Add workload identity pool namespace. #13920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stevenyang72
Copy link
Member

@stevenyang72 stevenyang72 commented May 13, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_iam_workload_identity_pool_namespace`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 268 insertions(+))
google-beta provider: Diff ( 11 files changed, 1183 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 150 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workload_identity_pool_namespace (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workload_identity_pool_namespace" "primary" {
  owner_service {
    principal_subject = # value needed
  }
}

@stevenyang72
Copy link
Member Author

Hi @liminw @kenmccracken-google @duobianxing, please review the following generated documentation:


How to view the rendered documentation?

  1. Copy the raw markdown documentation pointed by the URL.
  2. Open Terraform documentation preview tool: https://registry.terraform.io/tools/doc-preview
  3. Paste the file content to the text box of the preview tool.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 19
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • iambeta

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_full
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceBasicExample
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceFullExample
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_minimal

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMBetaWorkloadIdentityPoolNamespace_full [Debug log]
TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceBasicExample [Debug log]
TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceFullExample [Debug log]
TestAccIAMBetaWorkloadIdentityPoolNamespace_minimal [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 268 insertions(+))
google-beta provider: Diff ( 11 files changed, 1183 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 150 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workload_identity_pool_namespace (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workload_identity_pool_namespace" "primary" {
  owner_service {
    principal_subject = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iambeta

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 209 insertions(+))
google-beta provider: Diff ( 11 files changed, 1183 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 150 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workload_identity_pool_namespace (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workload_identity_pool_namespace" "primary" {
  owner_service {
    principal_subject = # value needed
  }
}

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iambeta

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants