Skip to content

Add a new resource google_dataplex_entry #13924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

mll
Copy link
Member

@mll mll commented May 13, 2025

Adding Terraform support for a Dataplex Entry resource.
Tracking issue: hashicorp/terraform-provider-google#19188

`google_dataplex_entry`

Marek Lipert and others added 30 commits April 16, 2025 14:33
…ailing), add aspect filtering logic to the decoder. Switch to using project number.
Modify Aspects to include 'aspect_value' subnode, add update tests (f…
Add the ability to create a dataplex entry. Add tests for this case.
…mples

The dependency between aspect types and entries has to be explicitly …
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2817 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2817 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 519 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 44
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • dataplex

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexEntry_dataplexEntryBasicExample
  • TestAccDataplexEntry_dataplexEntryFullExample
  • TestAccDataplexEntry_dataplexEntryUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexEntry_dataplexEntryBasicExample [Error message] [Debug log]
TestAccDataplexEntry_dataplexEntryFullExample [Error message] [Debug log]
TestAccDataplexEntry_dataplexEntryUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2823 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2823 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 519 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2823 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2823 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 519 insertions(+))

@mll mll changed the title Feature/dataplex entry aspect support Add a new resource google_dataplex_entry May 13, 2025
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 46
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexEntry_dataplexEntryFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataplexEntry_dataplexEntryFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 46
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexEntry_dataplexEntryFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataplexEntry_dataplexEntryFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@mll mll marked this pull request as ready for review May 13, 2025 19:18
@github-actions github-actions bot requested a review from SirGitsalot May 13, 2025 19:19
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants